RCORE-2126 Clear incomplete bootstraps when the connection is established #7983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build daniel.tabacaru_937Details
💛 - Coveralls |
danieltabacaru
force-pushed
the
dt/wrong_bootstrap
branch
from
2b72e9d to
2e3d7ed
Compare
danieltabacaru
force-pushed
the
dt/wrong_bootstrap
branch
from
2e3d7ed to
8ecb791
Compare
jbreams
approved these changes
Sep 27, 2024
|
@mpobrien Merging this PR will most likely break CI because baas is running out of memory. Is there something we can do on the baas side to fix this? fyi, we're using a baasaas image from sept 8th. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Clear incomplete bootstraps when the connection is established. Additionally, prevent re-processing pending bootstraps in the same session if it failed once already.
Fixes #7707.
☑️ ToDos
[ ] C-API, if public C++ API changed[ ]bindgen/spec.yml, if public C++ API changed